[UR] Add a UR device info enum for checking native bfloat16 conversions #17372

jinge90 · 2025-03-10T08:49:56Z

No description provided.

jinge90 · 2025-03-10T08:52:08Z

Hi, @steffenlarsen and @kbenzie
I drafted a PR to solve #17084 , could you help review to see whether we can proceed with this PR?
Thanks very much!

Signed-off-by: jinge90 <[email protected]>

steffenlarsen · 2025-03-11T06:54:55Z

unified-runtime/source/adapters/level_zero/device.cpp

+    if ((Device->ZeDeviceProperties->deviceId & 0xfff) == 0x201 ||
+        (Device->ZeDeviceProperties->deviceId & 0xff0) == 0xbd0)
+      return ReturnValue(true);
+    else
+      return ReturnValue(false);


Suggested change

if ((Device->ZeDeviceProperties->deviceId & 0xfff) == 0x201 ||

(Device->ZeDeviceProperties->deviceId & 0xff0) == 0xbd0)

return ReturnValue(true);

else

return ReturnValue(false);

return ReturnValue(

(Device->ZeDeviceProperties->deviceId & 0xfff) == 0x201 ||

(Device->ZeDeviceProperties->deviceId & 0xff0) == 0xbd0));

should this be in line with the changes here? https://github.com/intel/llvm/pull/17364/files

Done.
Thanks for pointing out this!

Hi, @steffenlarsen
Done.
Thanks very much.

steffenlarsen · 2025-03-11T06:56:21Z

unified-runtime/include/ur_api.h

  /// point
  UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS = 106,
+  /// [::ur_bool_t] support for native bfloat16 conversions
+  UR_DEVICE_INFO_BFLOAT16_CONVERSIONS_INTEL = 107,


Is there a reason this is added here and not as 122 after UR_DEVICE_INFO_PROGRAM_SET_SPECIALIZATION_CONSTANTS?

Hi, @steffenlarsen
At the beginning, I just used '122' but the pre-ci unified_runtime source check failed and asked to changed to '107', I don't know why the check asked so, just followed it.
Thanks very much.

This is because the new etor is added part way through the yaml array.

kbenzie · 2025-03-11T13:50:22Z

unified-runtime/scripts/core/device.yml

+    - name: BFLOAT16_CONVERSIONS_INTEL
+      desc: "[$x_bool_t] support for native bfloat16 conversions"


To avoid rewriting all of the enum values, move this new entry to the end of the array, i.e. after line 451.

Could you move this to the bottom and run the generate again please?

Hi, @kbenzie
Fixed.
Thanks very much.

kbenzie · 2025-03-11T13:51:03Z

unified-runtime/include/ur_api.h

  /// point
  UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS = 106,
+  /// [::ur_bool_t] support for native bfloat16 conversions
+  UR_DEVICE_INFO_BFLOAT16_CONVERSIONS_INTEL = 107,


This is because the new etor is added part way through the yaml array.

Signed-off-by: jinge90 <[email protected]>

npmiller

CUDA/HIP changes LGTM

Signed-off-by: jinge90 <[email protected]>

aarongreig · 2025-03-17T10:12:32Z

unified-runtime/test/conformance/device/urDeviceGetInfo.cpp

+TEST_P(urDeviceGetInfoTest, SuccessBFloat16) {
  size_t property_size = 0;
  const ur_device_info_t property_name = UR_DEVICE_INFO_BFLOAT16;


this is for the old deprecated bfloat16 query, there's a pr open to remove it https://github.com/intel/llvm/pull/17053/files#diff-4ad6c68f3c3e27ec6c124dab1d1c2cd28dc6bba6f4e0960f44eec79b3c0c1c98

for testing if you could just copy this function but rename the test and update property_name that'd be ideal, like this:

TEST_P(urDeviceGetInfoTest, SuccessBFloat16Conversions) { size_t property_size = 0; const ur_device_info_t property_name = UR_DEVICE_INFO_BFLOAT16_CONVERSIONS_INTEL;

kbenzie · 2025-03-17T10:20:05Z

unified-runtime/scripts/core/device.yml

      desc: "[$x_bool_t] support the $xProgramSetSpecializationConstants entry point"
    - name: USE_NATIVE_ASSERT
      desc: "[$x_bool_t] return true if the device has a native assert implementation."
+    - name: BFLOAT16_CONVERSIONS_INTEL


We should remove the _INTEL suffix here since we don't need to differentiate based on vendor for UR queries.

Hi, @kbenzie
I changed the enum name to "UR_BFLOAT_CONVERSIONS_NATIVE".
Thanks very much.

Signed-off-by: jinge90 <[email protected]>

aarongreig · 2025-03-25T17:30:47Z

unified-runtime/test/conformance/testing/source/utils.cpp

      device, UR_DEVICE_INFO_ATOMIC_MEMORY_SCOPE_CAPABILITIES, flags);
 }

+ur_result_t GetDeviceBFloat16ConversionsNativeSupport(ur_device_handle_t device,


this helper isn't used anywhere

Hi, @aarongreig
I removed the unused helper.
Thanks very much.

aarongreig · 2025-03-25T17:31:41Z

can you add a CTS test, it can be identical to this one

llvm/unified-runtime/test/conformance/device/urDeviceGetInfo.cpp

Line 2548 in e948e07

TEST_P(urDeviceGetInfoTest, SuccessUseNativeAssert) {

but obviously with the test name/enum switched

jinge90 · 2025-03-31T09:30:31Z

can you add a CTS test, it can be identical to this one

llvm/unified-runtime/test/conformance/device/urDeviceGetInfo.cpp

Line 2548 in e948e07

TEST_P(urDeviceGetInfoTest, SuccessUseNativeAssert) {

but obviously with the test name/enum switched

Hi, @aarongreig
I added the test, could you help review again?
Thanks very much.

Signed-off-by: jinge90 <[email protected]>

jinge90 · 2025-04-02T02:12:52Z

Hi, @intel/llvm-gatekeepers
Could you help merge this patch?
Thanks very much.

jinge90 requested review from a team as code owners March 10, 2025 08:49

jinge90 requested review from kbenzie and npmiller March 10, 2025 08:49

jinge90 temporarily deployed to WindowsCILock March 10, 2025 08:50 — with GitHub Actions Inactive

jinge90 requested a review from steffenlarsen March 10, 2025 08:50

jinge90 marked this pull request as draft March 10, 2025 08:50

jinge90 had a problem deploying to WindowsCILock March 10, 2025 09:08 — with GitHub Actions Error

jinge90 had a problem deploying to WindowsCILock March 10, 2025 09:09 — with GitHub Actions Error

[UR] Add a UR device info enum for checking native bfloat16 conversions

c7fda15

Signed-off-by: jinge90 <[email protected]>

jinge90 temporarily deployed to WindowsCILock March 10, 2025 09:27 — with GitHub Actions Inactive

fix clang format

e6235b3

Signed-off-by: jinge90 <[email protected]>

jinge90 temporarily deployed to WindowsCILock March 10, 2025 09:56 — with GitHub Actions Inactive

jinge90 temporarily deployed to WindowsCILock March 10, 2025 09:57 — with GitHub Actions Inactive

jinge90 temporarily deployed to WindowsCILock March 10, 2025 10:51 — with GitHub Actions Inactive

jinge90 temporarily deployed to WindowsCILock March 10, 2025 11:16 — with GitHub Actions Inactive

address ur source check

ab891ad

Signed-off-by: jinge90 <[email protected]>

steffenlarsen reviewed Mar 11, 2025

View reviewed changes

kbenzie reviewed Mar 11, 2025

View reviewed changes

kbenzie mentioned this pull request Mar 11, 2025

Add a new UR_DEVICE_INFO enum for checking bfloat16 native conversion in unified_runtime #17084

Closed

jinge90 temporarily deployed to WindowsCILock March 12, 2025 04:49 — with GitHub Actions Inactive

jinge90 temporarily deployed to WindowsCILock March 12, 2025 05:06 — with GitHub Actions Inactive

sync with latest syclos

bd898ef

Signed-off-by: jinge90 <[email protected]>

jinge90 marked this pull request as ready for review March 12, 2025 06:34

npmiller approved these changes Mar 12, 2025

View reviewed changes

jinge90 requested a review from steffenlarsen March 12, 2025 10:17

jinge90 temporarily deployed to WindowsCILock March 17, 2025 03:49 — with GitHub Actions Inactive

regenerate enum value for bfloat16_conv

bb6395c

Signed-off-by: jinge90 <[email protected]>

jinge90 temporarily deployed to WindowsCILock March 17, 2025 07:05 — with GitHub Actions Inactive

jinge90 temporarily deployed to WindowsCILock March 17, 2025 07:23 — with GitHub Actions Inactive

regenerate ur enum for bf16 convert

db6d7d3

Signed-off-by: jinge90 <[email protected]>

aarongreig reviewed Mar 17, 2025

View reviewed changes

kbenzie reviewed Mar 17, 2025

View reviewed changes

hvdijk approved these changes Mar 17, 2025

View reviewed changes

jinge90 had a problem deploying to WindowsCILock March 25, 2025 08:25 — with GitHub Actions Error

jinge90 temporarily deployed to WindowsCILock March 25, 2025 08:41 — with GitHub Actions Inactive

rename bf16 conversions intel to native

6d3a927

Signed-off-by: jinge90 <[email protected]>

jinge90 temporarily deployed to WindowsCILock March 25, 2025 09:01 — with GitHub Actions Inactive

add missing break

0c5ca0f

Signed-off-by: jinge90 <[email protected]>

aarongreig reviewed Mar 25, 2025

View reviewed changes

jinge90 added 2 commits March 26, 2025 15:41

Merge remote-tracking branch 'upstream/sycl' into ur_bf16_enum

985f363

Merge remote-tracking branch 'upstream/sycl' into ur_bf16_enum

6a04a69

jinge90 temporarily deployed to WindowsCILock March 31, 2025 09:29 — with GitHub Actions Inactive

aarongreig approved these changes Mar 31, 2025

View reviewed changes

jinge90 temporarily deployed to WindowsCILock March 31, 2025 09:39 — with GitHub Actions Inactive

add test for bfloat16 conversions

11762ee

Signed-off-by: jinge90 <[email protected]>

jinge90 requested a review from a team April 2, 2025 02:11

steffenlarsen merged commit 9c1cb9c into intel:sycl Apr 2, 2025
32 checks passed

		- name: BFLOAT16_CONVERSIONS_INTEL
		desc: "[$x_bool_t] support for native bfloat16 conversions"

[UR] Add a UR device info enum for checking native bfloat16 conversions #17372

[UR] Add a UR device info enum for checking native bfloat16 conversions #17372

Uh oh!

Conversation

jinge90 commented Mar 10, 2025

Uh oh!

jinge90 commented Mar 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

npmiller left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aarongreig commented Mar 25, 2025

Uh oh!

jinge90 commented Mar 31, 2025

Uh oh!

jinge90 commented Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants